fix: Empty Rancher Service Labels. #1654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
force-pushed
the
fix-rancher-missing-launch-config
branch
from
7314a48
to
3aa4e47
Compare
ldez
changed the title
ldez
force-pushed
the
fix-rancher-missing-launch-config
branch
from
07fcf70
to
9884728
Compare
emilevauge
reviewed
May 23, 2017
provider/rancher/rancher.go
Outdated
| for key, value := range service.LaunchConfig.Labels { | ||
| rancherData.Labels[key] = value.(string) | ||
| if service.LaunchConfig == nil || service.LaunchConfig.Labels == nil { | ||
| log.Warnf("Rancher Service Labels are missing.") |
There was a problem hiding this comment.
We may add service.Name in the log
ldez
force-pushed
the
fix-rancher-missing-launch-config
branch
from
9884728
to
5f9041b
Compare
ldez
force-pushed
the
fix-rancher-missing-launch-config
branch
from
5f9041b
to
3ff9dfd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1615