Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make port deterministic #1523

Merged
merged 1 commit into from
May 3, 2017
Merged

Make port deterministic #1523

merged 1 commit into from
May 3, 2017

Conversation

tanyadegurechaff
Copy link
Contributor

Description

Fixes #1148

@ldez ldez added kind/enhancement a new or improved feature. kind/bug/confirmed a confirmed bug (reproducible). kind/bug/fix a bug fix and removed kind/enhancement a new or improved feature. kind/bug/confirmed a confirmed bug (reproducible). labels May 1, 2017
@ldez ldez added this to the 1.3 milestone May 3, 2017
@emilevauge emilevauge requested a review from vdemeester May 3, 2017 08:33
emilevauge
emilevauge approved these changes May 3, 2017
View reviewed changes
Copy link
Member

@emilevauge emilevauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tanyadegurechaff
LGTM

vdemeester
vdemeester approved these changes May 3, 2017
View reviewed changes
Copy link
Contributor

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@ldez ldez force-pushed the make-port-deterministic branch from d1ef906 to 79cbe56 Compare May 3, 2017 13:29
@ldez ldez merged commit 91b4b47 into traefik:master May 3, 2017
@tanyadegurechaff tanyadegurechaff deleted the make-port-deterministic branch May 11, 2017 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilevauge emilevauge emilevauge approved these changes

@vdemeester vdemeester vdemeester approved these changes

Assignees
No one assigned
Labels
area/provider/docker kind/bug/fix a bug fix
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
5 participants
@tanyadegurechaff @vdemeester @emilevauge @timoreimann @ldez