Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chunked: disallow both zstd:chunked and eStargz TOCs #1778

Merged

Conversation

giuseppe
Copy link
Member

reject a layer if it contains both a zstd:chunked and an eStargz TOC since there are no guarantees that the two TOCs are consistent.

reject a layer if it contains both a zstd:chunked and an eStargz TOC
since there are no guarantees that the two TOCs are consistent.

Signed-off-by: Giuseppe Scrivano <[email protected]>
Copy link
Member

@rhatdan rhatdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Dec 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 72ed526 into containers:main Dec 15, 2023
18 checks passed
@mtrmac
Copy link
Collaborator

mtrmac commented Dec 20, 2023

Thanks; please do this in chunked/toc/GetTOCDigest as well, to make it unambiguous (and, given the current call stack, to catch this early).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants