Update to github.com/mtrmac/gpgme v0.1.2 #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes CVE-2020-8945 by incorporating proglottis/gpgme#23 . Other changes included by the rebase: - Support for gpgme_off_t (~no-op on Linux) - Wrapping a few more GPGME functions (irrelevant if we don't call them) Given how invasive the CVE fix is (affecting basically all binding code), it seems safer to just update the package (and be verifiably equivalent with upstream) than to backport and try to back out the few other changes. Performed by updating vendor conf, $ vndr github.com/mtrmac/gpgme and manually backing out unrelated deletions of files. Signed-off-by: Miloslav Trmač <[email protected]>
the package was renamed on Fedora 31. Signed-off-by: Giuseppe Scrivano <[email protected]>
Since GPG 2.1, GPG asks for a passphrase by default; opt out when generating test keys to avoid > gpg: agent_genkey failed: No pinentry > gpg: key generation failed: No pinentry which happens otherwise (and we can't use an interactive pinentry in a batch process anyway). Signed-off-by: Miloslav Trmač <[email protected]>
|
LGTM |
|
NOTE: This backports test suite changes necessary for recent Fedoras, which may be inappropriate for the RHEL target. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes CVE-2020-8945 by incorporating proglottis/gpgme#23 .
Other changes included by the rebase:
gpgme_off_t(~no-op on Linux)Given how invasive the CVE fix is (affecting basically all binding code), it seems safer to just update the package (and be verifiably equivalent with upstream) than to backport and try to back out the few other changes.
Performed by updating vendor conf,
$ vndr github.com/mtrmac/gpgmeand manually backing out unrelated deletions of files.