vendor latest c/{buildah,common,image,storage}

[Luap99]

Also add a regression test for the TZDIR + --tz=local issue that I fixed in c/common containers/common#2219

Does this PR introduce a user-facing change?

Fixed an issue where --tz=local could not be used when the TZDIR environment variable was set. 

[edsantiago]

There's one more change you might need from #13808, the skip.*secret

[mtrmac]

The buildah failure reproducer:

diff --git a/tests/bud/multiarch/Dockerfile.no-run b/tests/bud/multiarch/Dockerfile.no-run
index 959f4be2f..7313f2209 100644
--- a/tests/bud/multiarch/Dockerfile.no-run
+++ b/tests/bud/multiarch/Dockerfile.no-run
@@ -3,7 +3,7 @@
 ARG SAFEIMAGE
 
 # A base image that is known to be a manifest list.
-FROM docker.io/library/alpine
+FROM quay.io/libpod/alpine
 COPY Dockerfile.no-run /root/
 
 FROM $SAFEIMAGE
diff --git a/vendor/github.com/containers/common/libimage/pull.go b/vendor/github.com/containers/common/libimage/pull.go
index ad4699c60..dec3f82cb 100644
--- a/vendor/github.com/containers/common/libimage/pull.go
+++ b/vendor/github.com/containers/common/libimage/pull.go
@@ -5,6 +5,7 @@ package libimage
 import (
        "context"
        "errors"
+       "sync/atomic"
        "fmt"
        "io"
        "os"
@@ -686,6 +687,11 @@ func (r *Runtime) copySingleImageFromRegistry(ctx context.Context, imageName str
                        logrus.Errorf("Error recording short-name alias %q: %v", candidateString, err)
                }
 
+               pullCount := firstUse.Add(1)
+               logrus.Errorf("Pull count %d", pullCount)
+               if pullCount ==1 {
+                       time.Sleep(3*time.Minute)
+               }
                logrus.Debugf("Pulled candidate %s successfully", candidateString)
                ids, err := r.imageIDForPulledImage(candidate.Value, manifestBytes)
                if err != nil {
@@ -704,3 +710,5 @@ func (r *Runtime) copySingleImageFromRegistry(ctx context.Context, imageName str
 
        return "", resolved.FormatPullErrors(pullErrors)
 }
+
+var firstUse atomic.Int32

and

bin/buildah build --log-level=debug --jobs=0  --all-platforms --manifest localhost/testlist --build-arg SAFEIMAGE=quay.io/libpod/testimage:20221018  -f tests/bud/multiarch/Dockerfile.no-run tests/bud/multiarch/

I confirm the hypothesis: each per-platform pull moves the quay.io/libpod/alpine:latest tag, and with that, quay.io/libpod/alpine@sha256:… on the other platforms no longer matches anything.

[mtrmac]

Also confirming that reverting containers/common@aa722ef fixes this…

[mtrmac]

… and, that, alternatively, (today’s version of) containers/image#2609 + containers/common#2209 fixes this reproducer.

So I’d prefer this alternative (merging the two PRs) to the revert. I’ll also prepare a test Podman PR based on this one.

[mtrmac]

#24462 is running to POC the alternative of obtaining the image ID from c/image instead of doing a lookup.

[packit-as-a-service]

Cockpit tests failed for commit 8016809. @martinpitt, @jelly, @mvollmer please check.

[Luap99]

@containers/podman-maintainers PTAL

[lsm5]

LGTM. I'll defer to @edsantiago for the tests.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Luap99,lsm5]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[edsantiago]

Tests LGTM. I'm curious why bud remote tests pass even without https://github.com/containers/podman/pull/13808/files#diff-8ba024261bda9c3e2b398f3af7416765e8b179f0de7470d3794095069d34463e but not curious enough to spend time on it.

[rhatdan]

/lgtm