Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor in latest containers/buildah code #2090

Merged
merged 1 commit into from
Jan 7, 2019

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Jan 5, 2019

This should improve the speed of podman build.
Has fixes from containres/image for parallell pull.

Signed-off-by: Daniel J Walsh [email protected]

@rhatdan
Copy link
Member Author

rhatdan commented Jan 5, 2019

/approve
@TomSweeneyRedHat @umohnani8 @mheon @baude @vrothberg PTAL

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2019
@mheon
Copy link
Member

mheon commented Jan 5, 2019

Do we need a revendor of c/image to pick up the changes there?

@vrothberg
Copy link
Member

vrothberg commented Jan 5, 2019 via email

This should improve the speed of podman build.
Has fixes from containres/image for parallell pull.

Also vendor containers/storage and containers/image

Signed-off-by: Daniel J Walsh <[email protected]>
@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L labels Jan 5, 2019
@baude
Copy link
Member

baude commented Jan 7, 2019

c-image can be next. ill merge this one first.

@baude
Copy link
Member

baude commented Jan 7, 2019

/lgtm

@vrothberg
Copy link
Member

c-image can be next. ill merge this one first.

The thing is that without vendoring the new c/image, there are no pull improvements.

@vrothberg
Copy link
Member

c-image can be next. ill merge this one first.

The thing is that without vendoring the new c/image, there are no pull improvements.

Actually, it's fine as Dan updated the PR before it was merged :)

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants