Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup mount test bug #3953

Closed
gabibeyer opened this issue Sep 5, 2019 · 3 comments
Closed

cleanup mount test bug #3953

gabibeyer opened this issue Sep 5, 2019 · 3 comments
Assignees
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@gabibeyer
Copy link

gabibeyer commented Sep 5, 2019

Not entirely sure whether this is an issue with the test not working as originally intended, or if the code base may need some modifications and the test is correct.

The "podman run -d mount cleanup test" in the run_cleanup_test.go file was incorrectly using the Expect function (not providing a matcher), so it was passing regardless of the input. However, once Expect was used correctly, some tests are failing.

It looks like the mount is not actually getting cleaned up, or maybe not giving enough time for conmon to do the cleanup before checking results. Anyways, this can be seen in
this PR: #3941 . I'm not entirely sure how to move forward on this, and could use some help. I believe it is blocking #3756 (although maybe not entirely related to the PR).

Thank you,
Gabi

@rhatdan
Copy link
Member

rhatdan commented Sep 5, 2019

See if adding

		wait := podmanTest.Podman([]string{"wait", cid})
		wait.WaitWithDefaultTimeout()
		Expect(stop.ExitCode()).To(Equal(0))

After the stop fixes the issue.

@rhatdan
Copy link
Member

rhatdan commented Sep 5, 2019

I think this is definitely a race.

@mheon
Copy link
Member

mheon commented Sep 23, 2019

#3941 is merged, so this is fixed, closing

@mheon mheon closed this as completed Sep 23, 2019
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

No branches or pull requests

3 participants