Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a systemd- prefix to the name of pod's infra container created by Quadlet as well #23665

Closed
ruihe774 opened this issue Aug 19, 2024 · 2 comments · Fixed by #23676
Closed
Labels
kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. quadlet

Comments

@ruihe774
Copy link
Contributor

ruihe774 commented Aug 19, 2024

Feature request description

Containers and pods created by Quadlet have a systemd- prefix in their names to avoid conflicts with user-managed containers. However, the pod's infra container does not follow this naming convention. I propose that we can use a systemd- prefixed name by default for pod's infra container created by Quadlet.

Suggest potential solution

For example, a pod systemd-mypod can set systemd-mypod-infra as the name of its infra container.

Have you considered any alternatives?

No

Additional context

None

@ruihe774 ruihe774 added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 19, 2024
@Luap99 Luap99 added the quadlet label Aug 19, 2024
@rhatdan
Copy link
Member

rhatdan commented Aug 19, 2024

Care to open a PR?

@ruihe774
Copy link
Contributor Author

Care to open a PR?

OK. I'm going to work on it.

@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Nov 19, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Nov 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. quadlet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants