Publish does not work after upgrade

[afbjorklund]

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)

/kind bug

Description

It seems like something changed in the --publish syntax ?

--publish, -p=ip:hostPort:containerPort | ip::containerPort | hostPort:containerPort | containerPort

Publish a container's port, or range of ports, to the host.

Both hostPort and containerPort can be specified as a range of ports.

When specifying ranges for both, the number of container ports in the range must match the number of host ports in the range.

It no longer seems to accept the ip::containerPort variant.

Steps to reproduce the issue:

1. Use "podman run" with --publish parameteres

Describe the results you received:

$ sudo podman2 run --publish=127.0.0.1::8443 --publish=127.0.0.1::22 --publish=127.0.0.1::2376 --publish=127.0.0.1::5000 ubuntu:20.04
Error: must provide a non-empty container host port to publish

Describe the results you expected:

$ sudo podman1 run --publish=127.0.0.1::8443 --publish=127.0.0.1::22 --publish=127.0.0.1::2376 --publish=127.0.0.1::5000 ubuntu:20.04

Additional information you deem important (e.g. issue happens only occasionally):

Output of podman version:

1.8.2

2.0.0

Output of podman info --debug:

(paste your output here)

Package info (e.g. output of rpm -q podman or apt list podman):

(paste your output here)

Additional environment details (AWS, VirtualBox, physical, etc.):

Ubuntu 20.04

[afbjorklund]

As far as I can tell, it is either 7ac3d90 (or maybe 4e2a0b5)

Can't seem to find any unit tests for cmd/podman/common/util.go

[mheon]

Is that actually legal? Huh. Didn't think it was.

Should be a quick fix, let me grab this.

[mheon]

#6808 to fix

[afbjorklund]

Thanks! The idea is to pick a random port, where we are tunneling in those services:

• 8443: minikube (custom variant, 6443 kubernetes)
• 22: ssh
• 2376: docker
• 5000: registry

CONTAINER ID  IMAGE                                COMMAND  CREATED         STATUS             PORTS                                                                                                     NAMES
0a4c50ff1985  gcr.io/k8s-minikube/kicbase:v0.0.10           17 seconds ago  Up 17 seconds ago  127.0.0.1:41397->22/tcp, 127.0.0.1:35737->2376/tcp, 127.0.0.1:42677->5000/tcp, 127.0.0.1:36717->8443/tcp  crio

This for compatibility with both virtualbox (host-only network) and docker desktop VM

Otherwise one might as well have used the "front entrance" and used the CNI IP...

[mheon]

Reworked to choose a random port, thanks for pointing that out.

[skorhone]

@mheon Documentation should be updated to reflect this change. There's currently nothing about randomizing port for this operation.

There's also no mention, if you can specify combination of single container port and range of host ports. In this case, host port should be randomized from given range (if you wan't to follow docker's implementation)

[mheon]

I'll do the second bit in a separate PR.