Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose number of containers attached to a conmon-rs process #2020

Open
umohnani8 opened this issue Feb 20, 2024 · 5 comments
Open

Expose number of containers attached to a conmon-rs process #2020

umohnani8 opened this issue Feb 20, 2024 · 5 comments

Comments

@umohnani8
Copy link
Member

As part of the conmon-rs integration with podman, we need a way of querying conmon-rs to get the number of containers already attached to a single conmon-rs process.

This will help us determine whether to add a new container to an existing conmon-rs or to create a new conmon-rs process because we have reached the allowed limit.

Podman plans to keep a list of active conmon-rs processes so that we can go through those and query the number of containers attached to each one before making a decision.

@umohnani8
Copy link
Member Author

@haircommander PTAL

@haircommander
Copy link
Collaborator

would a ListContainers like API be useful? instead of just the number, include the IDs as well?

@umohnani8
Copy link
Member Author

Yes, that would be even better!

@saschagrunert
Copy link
Member

saschagrunert commented Feb 20, 2024

This will help us determine whether to add a new container to an existing conmon-rs or to create a new conmon-rs process because we have reached the allowed limit.

Is this something we should handle directly in conmon-rs (the golang client/API of it)?

@umohnani8
Copy link
Member Author

@saschagrunert yes I believe so. The plan is to use a conmon-rs id (or whatever its unique attribute is) and call the conmon-rs API with that id to get a list of containers (or number of containers) currently attached to that conmon-rs process.

This is the workflow I had in mind, but open to other ideas as well :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants