From 527151969a9d4043bb73851a33db246b84c45cd0 Mon Sep 17 00:00:00 2001 From: Colin Walters Date: Sat, 22 Jun 2024 09:20:18 -0400 Subject: [PATCH] tree: Add missing -v /dev:/dev in a few places We're really going to need to switch over to having the container do dynamic mounts; cc https://github.com/containers/bootc/issues/380#issuecomment-1983721453 Just noticed this missing in one place, and found others with a grep. Right now we do operate without, but it can be racier. Signed-off-by: Colin Walters --- hack/lldb/deploy.sh | 2 +- tests/integration/image-install-upgrade.sh | 1 + tests/integration/playbooks/install.yaml | 1 + 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/hack/lldb/deploy.sh b/hack/lldb/deploy.sh index 442ce9aa..99adad6a 100755 --- a/hack/lldb/deploy.sh +++ b/hack/lldb/deploy.sh @@ -11,7 +11,7 @@ sudo podman build --build-arg "sshpubkey=$(cat ~/.ssh/id_rsa.pub)" -f Containerf mkdir -p ~/.cache/bootc-dev/disks rm -f ~/.cache/bootc-dev/disks/lldb.raw truncate -s 10G ~/.cache/bootc-dev/disks/lldb.raw -sudo podman run --pid=host --network=host --privileged --security-opt label=type:unconfined_t -v /var/lib/containers:/var/lib/containers -v ~/.cache/bootc-dev/disks:/output -v /dev:/dev localhost/bootc-lldb bootc install to-disk --via-loopback --generic-image --skip-fetch-check /output/lldb.raw +sudo podman run --pid=host --network=host --privileged --security-opt label=type:unconfined_t -v /dev:/dev -v /var/lib/containers:/var/lib/containers -v ~/.cache/bootc-dev/disks:/output -v /dev:/dev localhost/bootc-lldb bootc install to-disk --via-loopback --generic-image --skip-fetch-check /output/lldb.raw # create a new VM in libvirt set +e diff --git a/tests/integration/image-install-upgrade.sh b/tests/integration/image-install-upgrade.sh index 24688023..f26fd61f 100755 --- a/tests/integration/image-install-upgrade.sh +++ b/tests/integration/image-install-upgrade.sh @@ -150,6 +150,7 @@ case "$IMAGE_TYPE" in --privileged \ --pid=host \ --security-opt label=type:unconfined_t \ + -v /dev:/dev \ -v /var/lib/containers:/var/lib/containers \ -v /dev:/dev \ -v .:/output \ diff --git a/tests/integration/playbooks/install.yaml b/tests/integration/playbooks/install.yaml index 1fdb93d1..77e37322 100644 --- a/tests/integration/playbooks/install.yaml +++ b/tests/integration/playbooks/install.yaml @@ -83,6 +83,7 @@ --rm \ --privileged \ --pid=host \ + -v /dev:/dev \ -v /:/target \ -v /var/lib/containers:/var/lib/containers \ --security-opt label=type:unconfined_t \