Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packit: disable F39 and separate out ELN #515

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Sep 23, 2024

We have disabled Fedora 39 on podman-next copr. So, it's best to disable build and tests for them here too.

This commit also separates out ELN jobs into a separate set using packages: [aardvark-dns-eln] key-value.

YAML anchors are also used for reusing fedora and centos stream targets for upstream and downstream jobs.

Copy link

Tests failed. @containers/packit-build please check.

.packit.yaml Outdated
Comment on lines 48 to 56
targets: &fedora_copr_targets
- fedora-development-x86_64
- fedora-development-aarch64
- fedora-latest-x86_64
- fedora-latest-aarch64
- fedora-latest-stable-x86_64
- fedora-latest-stable-aarch64
- fedora-40-x86_64
- fedora-40-aarch64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to not use fedora-all here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean even if f39 is disabled in the copr it should still build fine here in the tests but I guess overall it doesn't matter and I am fine to remove it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mainly because of reusing fedora_copr_targets in the test job below where fedora-39 would fail. I'm ok to have fedora-all and only use non-fedora-39 in the tests.

We have disabled Fedora 39 on podman-next copr. So, it's best to disable
build and tests for them here too.

This commit also separates out ELN jobs into a separate set using
`packages: [aardvark-dns-eln]` key-value.

YAML anchors are also used for reusing fedora and centos stream targets for upstream and
downstream jobs.

Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5 lsm5 force-pushed the packit-target-reorg branch from e828dc7 to 6b7741f Compare September 26, 2024 14:25
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Sep 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit fda45da into containers:main Sep 26, 2024
31 of 45 checks passed
@lsm5 lsm5 deleted the packit-target-reorg branch September 30, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants