macvlan cmdDel: replace the loadConf function with json.unmarshal #954
Conversation
cyclinder
force-pushed
the
improve_cmd_del
branch
2 times, most recently
from
a020c4e to
2cd6d82
Compare
cyclinder
force-pushed
the
improve_cmd_del
branch
from
2cd6d82 to
f7b49f7
Compare
|
looks good now, please improve the commit title and message. See https://cbea.ms/git-commit/ as reference. |
cyclinder
force-pushed
the
improve_cmd_del
branch
from
f7b49f7 to
dc27da3
Compare
cyclinder
changed the title
|
thanks @mlguerrero12, This is my first time contributing to CNI, Thank you for helping me. |
cyclinder
changed the title
|
In the description, you mention that the problem is when the pod's nic is deleted, but in reality the bug you are seeing is because the master interface is deleted and loadConf tries to get the MTU. The delete command only needs to unmarshall the net config. No need to get the MTU. Please update the description and wrap the body of the commit around 72 characters or so (as mentioned in bullet 6 of the link I shared above). Currently, you have a very long line as body which is difficult to read. |
cyclinder
force-pushed
the
improve_cmd_del
branch
from
dc27da3 to
4024ca9
Compare
|
thanks a lot @mlguerrero12. How about the latest description? |
cyclinder
force-pushed
the
improve_cmd_del
branch
from
4024ca9 to
dc1c5ec
Compare
|
LGTM Just a small nit: please correct the grammar mistakes in the body of the commit. @squeed, could you please have a look at this? |
When the master interface on the node has been deleted, and loadConf tries to get the MTU, This causes cmdDel to return a linkNotFound error to the runtime. The cmdDel only needs to unmarshal the netConf. No need to get the MTU. So we just replaced the loadConf function with json.unmarshal in cmdDel. Signed-off-by: cyclinder <[email protected]>
cyclinder
force-pushed
the
improve_cmd_del
branch
from
dc1c5ec to
845ef62
Compare
|
Updated, Thanks @mlguerrero12 @squeed |
|
Hey @mlguerrero12 @squeed, Is time to merge this? |
When the master interface on the node has been deleted, and loadConf tries
to get the MTU, This causes cmdDel to return a linkNotFound error to the
runtime. The cmdDel only needs to unmarshal the net config. No need to
get the MTU. So we just replaced the loadConf function with
json.unmarshal in cmdDel.
Fixes #953