Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clippy Fixes for latest rust (1.67) #171

Merged
merged 4 commits into from
Feb 13, 2023

Conversation

jsturtevant
Copy link
Collaborator

@jsturtevant jsturtevant commented Jan 30, 2023

Fixes linter by running cargo clippy --fix --all-features after updating to latest rust tool chain with rustup update stable which is run in CI.

Fixes building from main branch:

make 
cargo build --verbose --all-targets
 Compiling ttrpc v0.7.1 (/home/jstur/projects/ttrpc-rust)
error: variables can be used directly in the `format!` string
  --> src/common.rs:27:34
   |
27 |           return Err(Error::Others(format!(
   |  __________________________________^
28 | |             "failed to set listener fd: {} as non block: {}",
29 | |             listener, e
30 | |         )));
   | |_________^
   |
....

@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Base: 25.95% // Head: 25.71% // Decreases project coverage by -0.24% ⚠️

Coverage data is based on head (4ad4088) compared to base (d31099a).
Patch coverage: 10.34% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #171      +/-   ##
==========================================
- Coverage   25.95%   25.71%   -0.24%     
==========================================
  Files          16       16              
  Lines        2416     2399      -17     
==========================================
- Hits          627      617      -10     
+ Misses       1789     1782       -7     
Impacted Files Coverage Δ
src/asynchronous/client.rs 0.00% <0.00%> (ø)
src/asynchronous/server.rs 0.00% <0.00%> (ø)
src/asynchronous/stream.rs 0.00% <0.00%> (ø)
src/asynchronous/utils.rs 0.00% <0.00%> (ø)
src/sync/channel.rs 0.00% <0.00%> (ø)
src/sync/client.rs 0.00% <0.00%> (ø)
src/sync/server.rs 0.00% <0.00%> (ø)
src/common.rs 35.57% <25.00%> (+0.99%) ⬆️
src/proto.rs 90.06% <100.00%> (-0.10%) ⬇️
src/asynchronous/shutdown.rs 96.96% <0.00%> (-0.11%) ⬇️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Fix clippy lint errors for rust 1.67

Signed-off-by: James Sturtevant <[email protected]>
Fix clippy lint errors for rust 1.67 for codegen

Signed-off-by: James Sturtevant <[email protected]>
@wllenyj
Copy link
Collaborator

wllenyj commented Jan 31, 2023

There is a problem with the title of the second commit.
Fix lint errors for for macos
5eec980

Fix clippy lint errors for rust 1.67 for macos

Signed-off-by: James Sturtevant <[email protected]>
rustfmt updates for 1.67 in codegen

Signed-off-by: James Sturtevant <[email protected]>
@jsturtevant
Copy link
Collaborator Author

There is a problem with the title of the second commit. Fix lint errors for for macos 5eec980

updated

Copy link
Member

@Tim-Zhang Tim-Zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @jsturtevant

@Tim-Zhang Tim-Zhang merged commit 8c5121f into containerd:master Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants