-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test login, push (and authenticated pull) against docker hub #3494
Comments
Probably those tests should be only executed on a laptop outside the CI |
That would be a good start - and we can re-evaluate later. |
Good point but as open source product our first target is to fill the oci distribution requirement. Hard to satisfy all oci distribution implemention (Hub, harbor..). Otherwise fork nerdctl and statisfy specific distribution implem is a nice solution ( this is what private organization does) |
Fair. |
As I see it, (one of) the problem with open-source is that people do reap the benefits and do not contribute back. My point being: we should make nerdctl such a compelling proposal that people should feel enticed to contribute here, and we should encourage that by giving them the means to do so. I hope I am making sense :-). Anyhow, philosophizing here... |
What is the problem you're trying to solve
Right now, we do test most of our registry operations against a locally started distribution registry + cesanta token auth server.
This is good, but has limits. Specifically, Docker Hub resolution mechanisms are "special", be it the way the credentials are stored in the store, or how short names resolve to fully qualified url - and also their token auth server is proprietary IIRC, which might entail some specific behaviors.
We do not currently test that, and have seen a couple of regression recently (#3484, #3485) that could have been caught if we did.
Testing against Hub comes with challenges:
A possible solution would be to run these tests against Hub solely on master (after merge).
This ticket is related to #3257 - and also testing against Gitlab.
Describe the solution you'd like
na
Additional context
No response
The text was updated successfully, but these errors were encountered: