Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should have a publish scripts for the testing images we need, and we should not depend on third party images #3480

Open
apostasie opened this issue Oct 2, 2024 · 4 comments
Labels
area/ci e.g., CI failure

Comments

@apostasie
Copy link
Contributor

Description

See #3479 for the last straw.

Our tests do depend on a number of images that we do not control - usually on Docker Hub.
There are good reasons to test Docker Hub - just not to use third party images.

Also, even for the images that do not change (hosted on ghcr.io), we do not have a way to repush them if we needed to.

Suggesting we create a nerdctl account on hub, and start pushing the images we need there.

@AkihiroSuda I can take care of this, but then I would need to transfer the account to you.
Or you take care of it directly instead.

Then I can come up with a script that would push everything we need and we get rid of the dependencies on busybox (etc.).

LMK.

Steps to reproduce the issue

na

Describe the results you received and expected

na

What version of nerdctl are you using?

na

Are you using a variant of nerdctl? (e.g., Rancher Desktop)

None

Host information

No response

@apostasie apostasie added the kind/unconfirmed-bug-claim Unconfirmed bug claim label Oct 2, 2024
@AkihiroSuda
Copy link
Member

AkihiroSuda commented Oct 2, 2024

We already have: https://github.com/stargz-containers/image-ci
( Plain vanilla non-estargz images are mirrored too with -org suffix https://github.com/orgs/stargz-containers/packages/container/alpine/17932394?tag=3.15.3-org )

@AkihiroSuda AkihiroSuda added area/ci e.g., CI failure and removed kind/unconfirmed-bug-claim Unconfirmed bug claim labels Oct 2, 2024
@apostasie
Copy link
Contributor Author

We already have: https://github.com/stargz-containers/image-ci ( Plain vanilla non-estargz images are mirrored too with -org suffix https://github.com/orgs/stargz-containers/packages/container/alpine/17932394?tag=3.15.3-org )

We still need images on the Hub to test hub behavior.

@AkihiroSuda
Copy link
Member

What behavior of hub?

@apostasie
Copy link
Contributor Author

What behavior of hub?

Resolution of shortnames and authentication.
Generally, we should still make sure we work well with Hub (regardless of what we think of it).

I see your point though - we might be able to do what we need without making assumptions on the images content.

I'll see what I can do to yank out busybox out of problem tests and come back here eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci e.g., CI failure
Projects
None yet
Development

No branches or pull requests

2 participants