Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build tags for optional features? #3463

Open
apostasie opened this issue Sep 25, 2024 · 2 comments
Open

Build tags for optional features? #3463

apostasie opened this issue Sep 25, 2024 · 2 comments

Comments

@apostasie
Copy link
Contributor

What is the problem you're trying to solve

Optional / experimental features (IPFS, stargz, nydus, overlaybd, etc) do introduce a fair amount of code and a number of tests that implementors may not be interested in (wether with straight nerdctl builds, or custom cli based on the codebase).

This is especially impactful as IPFS/stargz testing for example is very flimsy and failing builds a lot.

Suggestion here would be to introduce build tags for these to make it either to not compile support in / not test it.

WDYT?

Tagging @AkihiroSuda

Describe the solution you'd like

na

Additional context

No response

@AkihiroSuda
Copy link
Member

AkihiroSuda commented Sep 25, 2024

NERDCTL_EXPERIMENTAL=0 (run-time env var) isn't enough?

@apostasie
Copy link
Contributor Author

NERDCTL_EXPERIMENTAL=0 (run-time env var) isn't enough?

That works only for the nerdctl binary right?
Custom cli using the repo as a library will not benefit from it.

The concern outlined in this ticket is not for end-users using the vanilla nerdctl, but for embedders / developers of custom clis.

Anyhow, this is somewhat low-priority.
If you don't like it, we can close - otherwise I may look into it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants