-
Notifications
You must be signed in to change notification settings - Fork 348
[release/1.3] Sync vendors with containerd 1.3.2 #1391
[release/1.3] Sync vendors with containerd 1.3.2 #1391
Conversation
Look through the `containerd dependencies` in vendor.conf, for each dependency / SHA, check if the SHA is newer in containerd's vendor.conf in 1.3.2 tag. Update if necessary. Drop unused packages. Signed-off-by: Davanum Srinivas <[email protected]>
Hi @dims. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
first commit LGTM
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
2nd commit needs a signature :)
Signed-off-by: Davanum Srinivas <[email protected]>
whoops fixing 2nd commit! |
@mikebrow is there a way to re-trigger the travis CI build? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (if green)
@thaJeztah @mikebrow looks like the |
Yes, it should. |
Looks like that was this PR: #1309, which related to containerd/containerd#3711, and was back ported to the containerd 1.3 branch in containerd/containerd#3753, so yes looks like it needs to be backported |
oh, LOL @mikebrow beated me to it (high five! ✋) |
(cherry picked from commit 2ce0bb0) Signed-off-by: Davanum Srinivas <[email protected]>
@thaJeztah @mikebrow i've added another commit with the backport for dropping the broken test. thanks! |
/test pull-cri-containerd-verify |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Look through the
containerd dependencies
in vendor.conf, for eachdependency / SHA, check if the SHA is newer in containerd's vendor.conf
in 1.3.2 tag. Update if necessary.
Drop unused packages. Add versions for missing packages.
cherry pick 2ce0bb0 as well to drop broken test