Skip to content
This repository has been archived by the owner on Mar 9, 2022. It is now read-only.

Need a switch to disable hard enforce of huge page limits (legacy issue) #1500

Closed
mikebrow opened this issue Jun 1, 2020 · 5 comments
Closed
Assignees
Milestone

Comments

@mikebrow
Copy link
Member

mikebrow commented Jun 1, 2020

kubernetes-sigs/kind#1637 (comment)

initial issue resolved...

Is now a documentation issue to explain which releases have support, the default option for filtering where the limits are not supported, and enabling hard errors if not supported.

@dims
Copy link
Member

dims commented Jun 1, 2020

working on a fix in #1501

@mikebrow
Copy link
Member Author

mikebrow commented Jun 2, 2020

leaving this issue open till we have fully documented the issue

@dims
Copy link
Member

dims commented Jun 8, 2020

@mikebrow are we happy where we have the flag currently? which docs should i fix up?

@mikebrow mikebrow added this to the v1.4 milestone Jun 8, 2020
@mikebrow
Copy link
Member Author

mikebrow commented Jun 8, 2020

needs a couple lines here:
https://github.com/containerd/cri/blame/master/docs/config.md#L84

This will explain the option in containerd config default:

    tolerate_missing_hugepages_controller = true

We don't have a table for support (or non) of such features.. have to think about that. But if we did it should probably go here (or at least be referenced from here):
https://github.com/containerd/cri#support-metrics

We'll want to highlight this change for the next containerd/containerd 1.4 release with a release note blurb. Can draft the release note text in this docs update or add it to #1501.

@AkihiroSuda
Copy link
Member

Now we have the flag:

  # tolerate_missing_hugetlb_controller if set to false will error out on create/update
  # container requests with huge page limits if the cgroup controller for hugepages is not present.
  # This helps with supporting Kubernetes <=1.18 out of the box. (default is `true`)
  tolerate_missing_hugetlb_controller = true

https://github.com/containerd/cri/blob/master/docs/config.md

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants