Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(binary-builder): defer version asset upload #1089

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

viceice
Copy link
Member

@viceice viceice commented Nov 25, 2024

Should be deferred until at least one binary aset is uploaded. Otherwise we've an empty release like it happned on php 8.4.1

@viceice viceice enabled auto-merge (squash) November 25, 2024 15:37
@viceice viceice requested a review from rarkins November 25, 2024 15:38
@viceice viceice merged commit ac65579 into main Nov 25, 2024
7 checks passed
@viceice viceice deleted the fix/defer-version-asset-upload branch November 25, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant