refactor: streamline image building process #46
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
| bc := m.buildBinary(ctx, platform, pkg) | ||
| img := dag.Container(dagger.ContainerOpts{Platform: dagger.Platform(platform)}). | ||
| WithFile("/"+pkg, bc.Container.File(bc.BinaryPath)). | ||
| WithEntrypoint([]string{"/" + pkg}) | ||
| return img | ||
| } | ||
|
|
||
| func (m *Harbor) BuildAllBinaries(ctx context.Context) *dagger.Directory { |
There was a problem hiding this comment.
I still would like to build binaries and have them on my host.
Its not clear to me how I can use BuildImages function and get to the binaries out of that array, so that I can copy them to the host
With a single image it woudl work but not with an array
Suggested way of setting a default for the "build-all" behavior without writing too much additional stuff. I also suggest standardizing on the container as the output of the build process instead of returning individual binaries