Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need a Gcntree_node_data type #14

Open
nlevenson opened this issue Mar 16, 2021 · 0 comments
Open

We need a Gcntree_node_data type #14

nlevenson opened this issue Mar 16, 2021 · 0 comments

Comments

@nlevenson
Copy link

We often want to compare Gcntree_nodes to determine what part of a standard schema they represent. To do this, we probably need a Gcapp_node_data type which is parameterized according to the standard schema it's associated with -- i.e., there's a Gcapp_node_data.type property which stores the hash of the part of the schema it's associated with, such that we can easily determine how a Gcntree_node corresponds to the standard schema which defines the standard it was derived from.

We currently use brittle and bad methods to make these kinds of comparisons, like checking typeof node.data. These brittle methods typically make some gross assumptions about the design of a standard schema.

@nlevenson nlevenson changed the title We need a Gcapp_node_data type We need a Gcntree_node_data type Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant