Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: text lines print twice #670

Open
spoutn1k opened this issue Nov 26, 2024 · 7 comments
Open

Regression: text lines print twice #670

spoutn1k opened this issue Nov 26, 2024 · 7 comments

Comments

@spoutn1k
Copy link
Contributor

We observed a regression after my series of patches. In some configurations the text output would be doubled and result in output of the form:

[root@node ~]# ./executable
Message 1/4
Message 1/4
Message 2/4
Message 2/4
⠉ [3s] [=>                  ] 2/100 Progress message

I'm fully committed to fixing my mess and have identified the change responsible.

@djc
Copy link
Member

djc commented Nov 27, 2024

Thanks for looking at this! Someone else also reported #669 which seems like it might have been caused by your changes.

@spoutn1k
Copy link
Contributor Author

They mention 0.17.9, which does not include my patch, right ?

@djc
Copy link
Member

djc commented Nov 28, 2024

They mention 0.17.9, which does not include my patch, right ?

Hmm, you're right.

@infiniteregrets
Copy link

infiniteregrets commented Dec 14, 2024

hi, I think i am facing this same issue on 0.17.9

i have Multiprogress instance containing two bars, when I abandon or finish either of the bars, it closes with two bars for one of them

Screenshot 2024-12-13 at 11 08 22 PM

@spoutn1k
Copy link
Contributor Author

spoutn1k commented Dec 14, 2024

Try the new master, the fix just got merged in

@infiniteregrets
Copy link

infiniteregrets commented Dec 14, 2024

Try the new master, the fix just got merged in

hi, I just tried the main branch and it still persists for me, when I do ctrl + C it gets printed twice ): I started working on a minimal reproduceable but haven't had the time to properly get it

@spoutn1k
Copy link
Contributor Author

spoutn1k commented Dec 14, 2024

Then hopefully it is #669 ... You confirm it is bars that get printed twice, and not println lines ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants