Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallet balances returns even if bogus RPC #364

Closed
jsoares opened this issue Nov 3, 2023 · 1 comment
Closed

wallet balances returns even if bogus RPC #364

jsoares opened this issue Nov 3, 2023 · 1 comment
Assignees
Labels
bug Something isn't working s:ipc

Comments

@jsoares
Copy link
Contributor

jsoares commented Nov 3, 2023

Issue type

Bug

Have you reproduced the bug with the latest dev version?

Yes

Version

dev

Custom code

Yes

OS platform and distribution

No response

Describe the issue

./bin/ipc-cli wallet balances returns no error even if using a bad (non-existent) RPC in the config; it just returns 0 balances for every wallet. The expected behaviour would be to return an error.

Repro steps

Run ./bin/ipc-cli wallet balances --subnet XXX --wallet-type evm using a well-formed but bogus RPC endpoint in the ipc-cli config.

Relevant log output

# Correct RPC
ubuntu@ip-172-26-12-88:~/ipc$ ./bin/ipc-cli wallet balances --subnet /r314159/t410fqypdmnt3tyfczkis6iobfgqq72yk4web4ytehdi --wallet-type evm
0x310c8812089ee8efce8b06302ecf58a5c0fe549b - Balance: 1.0
0xc3964d4b507cb3dc4f24a5f0962fd7339ea568a7 - Balance: 0.0
0x93ef94dc6bda3283263366e569b0a0ffda1677b7 - Balance: 1.0
0x5126aa09cde4d5d85fc080cc3c069a8098eb2e10 - Balance: 1.0
default-key - Balance: 0

# Bogus RPC
ubuntu@ip-172-26-12-88:~/ipc$ ./bin/ipc-cli wallet balances --subnet /r314159/t410fqypdmnt3tyfczkis6iobfgqq72yk4web4ytehdi --wallet-type evm
default-key - Balance: 0
0xc3964d4b507cb3dc4f24a5f0962fd7339ea568a7 - Balance: 0
0x5126aa09cde4d5d85fc080cc3c069a8098eb2e10 - Balance: 0
0x310c8812089ee8efce8b06302ecf58a5c0fe549b - Balance: 0
0x93ef94dc6bda3283263366e569b0a0ffda1677b7 - Balance: 0
@adlrocha
Copy link
Contributor

adlrocha commented Nov 6, 2023

@jsoares, fix here: #379 I tested it and seems to work for me, can you confirm?

@adlrocha adlrocha closed this as completed Nov 6, 2023
@jsoares jsoares transferred this issue from consensus-shipyard/ipc-libs Dec 19, 2023
@jsoares jsoares added the s:ipc label Dec 19, 2023
@jsoares jsoares closed this as not planned Won't fix, can't repro, duplicate, stale Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working s:ipc
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants