Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

block_by_height and header_by_height return different blocks #324

Closed
aakoshh opened this issue Jul 18, 2023 · 0 comments
Closed

block_by_height and header_by_height return different blocks #324

aakoshh opened this issue Jul 18, 2023 · 0 comments
Assignees
@adlrocha
Labels
bug Something isn't working s:fendermint

Comments

@aakoshh
Copy link
Contributor

aakoshh commented Jul 18, 2023

Within the Ethereum API, block_by_height applies -1 to the block height when it's queried for the "latest" block, but header_by_height does not. This is accidental, they should return consistent results.

https://github.com/consensus-shipyard/fendermint/blob/master/fendermint/eth/api/src/state.rs#L100-L157
@aakoshh aakoshh added the bug Something isn't working label Jul 18, 2023
@adlrocha adlrocha self-assigned this Aug 29, 2023
@jsoares jsoares transferred this issue from consensus-shipyard/fendermint Dec 19, 2023
@jsoares jsoares closed this as not planned Won't fix, can't repro, duplicate, stale Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adlrocha adlrocha

Labels
bug Something isn't working s:fendermint
Projects
No open projects
IPC Fendermint
Status: No status
IPC bug tracker
Status: In Progress
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jsoares @aakoshh @adlrocha