Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propose resolved bottom-up checkpoints in ProposalInterpreter::prepare #309

Closed
Tracked by #231
aakoshh opened this issue Aug 15, 2023 · 0 comments · Fixed by consensus-shipyard/fendermint#203
Closed
Tracked by #231

Propose resolved bottom-up checkpoints in ProposalInterpreter::prepare #309

aakoshh opened this issue Aug 15, 2023 · 0 comments · Fixed by consensus-shipyard/fendermint#203
Assignees
@aakoshh
Labels
s:fendermint

Comments

@aakoshh
Copy link
Contributor

aakoshh commented Aug 15, 2023 •
edited
Loading

Depends on a checkpoint being marked as resolved in #311

Implement ProposalInterpreter::prepare (added in consensus-shipyard/fendermint#185) by fetching resolved checkpoints from the pool and adding them to the block proposal as ChainMessage::Ipc(IpcMessage::BottomUpExec(_)).

Do not remove them from the pool as there is no guarantee that the proposal will go through.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aakoshh aakoshh

Labels
s:fendermint
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FM-195: Implement ProposalInterpreter::prepare for BottomUp consensus-shipyard/fendermint
2 participants
@jsoares @aakoshh