Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FM: Message selection logic #232

Closed
Tracked by #199
adlrocha opened this issue Aug 2, 2023 · 1 comment
Closed
Tracked by #199

FM: Message selection logic #232

adlrocha opened this issue Aug 2, 2023 · 1 comment

Comments

@adlrocha
Copy link
Contributor

adlrocha commented Aug 2, 2023

AFAIK, Fendermint doesn't currently have any message selection logic. It checks that the transactions included in a block doesn't overflow its size limit, but doesn't follow any strategy to determine what messages to include if there are more than the ones that fit a block.

We should include a really simple strategy initially with clear abstraction to easily change them (or even allow users to choose the one that fit them best). For the initial implementation, as discussed sync we will:

  • Order eligible messages in the pool by their premium (i.e. miner tip).
  • Include them until the total size of the block is reached.
  • (optionally) Check if there are any messages left that could fill the space left in the block after including all of the messages (if the last messages was index n, we would iterate from n to the total size s to see if there's any additional message that could fit the space left in the block).
@aakoshh
Copy link
Contributor

aakoshh commented Oct 6, 2023

A related issues is #349

@jsoares jsoares transferred this issue from consensus-shipyard/fendermint Dec 19, 2023
@jsoares jsoares closed this as not planned Won't fix, can't repro, duplicate, stale Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: No status
Development

No branches or pull requests

3 participants