Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method in the Gateway to return the checkpoint interval #210

Closed
aakoshh opened this issue Sep 7, 2023 · 1 comment · Fixed by consensus-shipyard/fendermint#267
Closed
Assignees

Comments

@aakoshh
Copy link
Contributor

aakoshh commented Sep 7, 2023

The Fendermint interpreter needs to know the checkpointing boundary to know when to construct a checkpoint.

An alternative to this is if the Gateway has an "end block" method and does the height checks on its own, but then it needs to return much more than if we break these out into methods, and Fendermint would tell from the return value whether a transition has taken place or not.

@dnkolegov
Copy link
Contributor

bottomUpCheckPeriod method of GatewayGetterFacet can be used for that

@aakoshh aakoshh self-assigned this Sep 14, 2023
@jsoares jsoares transferred this issue from consensus-shipyard/fendermint Dec 19, 2023
@jsoares jsoares closed this as not planned Won't fix, can't repro, duplicate, stale Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants