Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Fendermint from crashing when a contract is reverted in top-down and bottom-up logic #195

Closed
adlrocha opened this issue Oct 24, 2023 · 0 comments

Comments

@adlrocha
Copy link
Contributor

Right now, there are several processes in the logic from top-down and bottom-up cross-net primitives (like the commitment of top-down finality or the bottom-up checkpoint creation and signature) that make the Fendermint process to crash when this shouldn't be the behavior. We can crash a validator as long as all validators crash consistently and the process is not consensus breaking.

For additional context, from @aakoshh comment here

For posterity: I see we are crashing if any of the 3 parts of the execution of top-down finality goes wrong.

I think that's not a bad way to go in the next two weeks, but I maintain that we should rethink our approach to execution to respect gas limits:

@raulk raulk added bug Something isn't working and removed bug Something isn't working labels Nov 27, 2023
@jsoares jsoares transferred this issue from consensus-shipyard/fendermint Dec 19, 2023
@jsoares jsoares closed this as not planned Won't fix, can't repro, duplicate, stale Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Triage
Development

No branches or pull requests

3 participants