Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subnet registry storage clean up #1217

Open
cryptoAtwill opened this issue Nov 27, 2024 · 0 comments
Open

Subnet registry storage clean up #1217

cryptoAtwill opened this issue Nov 27, 2024 · 0 comments
Labels
improvement non-functional change

Comments

@cryptoAtwill
Copy link
Contributor

There are fields in SubnetRegistryStorage related to rewards, two of them are

address SUBNET_ACTOR_REWARD_FACET;
and
bytes4[] subnetActorRewarderSelectors;

these should be removed as it's for collateral withdraw only, part of a legacy code and only for collateral based power mode. It's not really at the facet level. It should not be confused with the validator reward facet from activity. It should be removed in the upcoming contract refactor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement non-functional change
Projects
Status: Backlog
Development

No branches or pull requests

1 participant