-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce new base fee in mempool after gas market base fee update #1183
Comments
There are two main solutions proposed:
Method 2 is preferred at the moment. |
when you say,
do this imply that during time of zero network usage (zero block gas utilization), that a user could set |
@sanderpick zero network usage should not have cause base fee to 0, the current gas market actor has a |
cool, makes sense. so instead of "message in mempool below the new base fee, should be deprioritised for message selection", it should just be rejected / dropped |
@sanderpick Not sure if we should drop them, because base fee varies, so next block those txns might have reached the base fee requirement. |
Hey @cryptoAtwill, how's this one coming? |
@sanderpick , the PR is ok for review, despite many changes in the main. |
With the introduction of gas market, block gas limit and base fee rotation were introduced. However, there is a missing piece when the base fee is updated, it should be enforced in the mempool for message selections: i.e. message in mempool below the new base fee, should be deprioritised for message selection.
The text was updated successfully, but these errors were encountered: