IPC-299: Implementation of provider methods #309
Conversation
| Some(addr) => addr, | ||
| }; | ||
|
|
||
| conn.manager().list_child_subnets(gateway_addr).await |
There was a problem hiding this comment.
Gateway address should not be needed in list_child_subnets as manager should already know which subnet it is managing and hence should have already known the gateway address. Ideally, manager should have owned the gateway address?.
There was a problem hiding this comment.
As this is a huge change, I will fix it in a follow up PR. Tracked in this issue: https://github.com/consensus-shipyard/ipc-agent/issues/316
| ) -> anyhow::Result<ChainEpoch> { | ||
| todo!() | ||
| let parent = subnet.parent().ok_or_else(|| anyhow!("no parent found"))?; |
There was a problem hiding this comment.
maybe we should remove this as well, so that we can fund address in root subnets
There was a problem hiding this comment.
I don't think this is the case, right? When funding you need to connect to the parent and send a fund to the gateway. So there shouldn't be a fund from the root as an argument.
IPC-299: implement get-chain-id
IPC-299: Cli checkpoint commands implementation
IPC-299: Implement cli cross-msg methods
IPC-299: Implementation of subnet cli commands
This PR includes the implementation of all the relevant methods currently required for the cli in the
IpcProvider.