From 156c26eb0183d9042b510023a96d20c6cbc29d41 Mon Sep 17 00:00:00 2001 From: dockercui Date: Mon, 22 Apr 2024 21:20:31 +0800 Subject: [PATCH] chore: fix some typos in comments Signed-off-by: dockercui --- packages/agents/lighthouse/test/mock.ts | 2 +- packages/agents/router/test/mock.ts | 2 +- .../agents/watcher/test/operations/validateAndPause.spec.ts | 2 +- .../agents/watcher/test/operations/validateAndSwitch.spec.ts | 2 +- .../deployments/contracts/contracts/messaging/RootManager.sol | 2 +- .../contracts_forge/core/connext/libraries/AssetLogic.t.sol | 4 ++-- .../subgraph/src/amarok-hub-staging/mapping/rootManager.ts | 2 +- packages/integration/README.md | 2 +- 8 files changed, 9 insertions(+), 9 deletions(-) diff --git a/packages/agents/lighthouse/test/mock.ts b/packages/agents/lighthouse/test/mock.ts index d86549d8b3..581a36930d 100644 --- a/packages/agents/lighthouse/test/mock.ts +++ b/packages/agents/lighthouse/test/mock.ts @@ -335,7 +335,7 @@ export const mock = { }, wallet: (): SinonStubbedInstance => { const wallet = createStubInstance(Wallet); - // need to do this differently bc the function doesnt exist on the interface + // need to do this differently bc the function doesn't exist on the interface (wallet as any).address = mock.address.router; wallet.getAddress.resolves(mock.address.router); wallet.signMessage.resolves(mock.signature); diff --git a/packages/agents/router/test/mock.ts b/packages/agents/router/test/mock.ts index 54c78cbe35..8c0f21b6af 100644 --- a/packages/agents/router/test/mock.ts +++ b/packages/agents/router/test/mock.ts @@ -124,7 +124,7 @@ export const mock = { adapters: { wallet: (): SinonStubbedInstance => { const wallet = createStubInstance(Wallet); - // need to do this differently bc the function doesnt exist on the interface + // need to do this differently bc the function doesn't exist on the interface (wallet as any).address = mock.address.router; wallet.getAddress.resolves(mock.address.router); wallet.signMessage.resolves(mock.signature); diff --git a/packages/agents/watcher/test/operations/validateAndPause.spec.ts b/packages/agents/watcher/test/operations/validateAndPause.spec.ts index 9c77c8eb6f..7748f9ef2c 100644 --- a/packages/agents/watcher/test/operations/validateAndPause.spec.ts +++ b/packages/agents/watcher/test/operations/validateAndPause.spec.ts @@ -14,7 +14,7 @@ describe("Operations:validateAndPause", () => { validateAndPauseStub = stub(ValidateAndPauseFns, "pauseAndAlert").resolves(); }); - it("should not call pauseAndAlert if it doesnt need pause", async () => { + it("should not call pauseAndAlert if it doesn't need pause", async () => { (ctxMock.adapters.watcher.checkInvariants as SinonStub).resolves({ needsPause: false }); await ValidateAndPauseFns.validateAndPause(); expect(validateAndPauseStub.callCount).to.be.eq(0); diff --git a/packages/agents/watcher/test/operations/validateAndSwitch.spec.ts b/packages/agents/watcher/test/operations/validateAndSwitch.spec.ts index 5ea85761bd..d3c33b7e13 100644 --- a/packages/agents/watcher/test/operations/validateAndSwitch.spec.ts +++ b/packages/agents/watcher/test/operations/validateAndSwitch.spec.ts @@ -16,7 +16,7 @@ describe("Operations:validateAndSwitch", () => { validateAndSwitchStub = stub(validateAndSwitchFns, "switchAndAlert").resolves(); }); - it("should not call switchAndAlert if it doesnt need pause", async () => { + it("should not call switchAndAlert if it doesn't need pause", async () => { (ctxMock.adapters.monitor.validateProposal as SinonStub).resolves({ needsSwitch: false }); await validateAndSwitchFns.validateAndSwitch(); expect(validateAndSwitchStub.callCount).to.be.eq(0); diff --git a/packages/deployments/contracts/contracts/messaging/RootManager.sol b/packages/deployments/contracts/contracts/messaging/RootManager.sol index 2e9788390e..0a5a78cecd 100644 --- a/packages/deployments/contracts/contracts/messaging/RootManager.sol +++ b/packages/deployments/contracts/contracts/messaging/RootManager.sol @@ -69,7 +69,7 @@ contract RootManager is ProposedOwnable, IRootManager, WatcherClient, DomainInde /** * @notice Emitted when a root is propagated - * @dev It doesnt matter if the root was generated optimistically or on-chain. + * @dev It doesn't matter if the root was generated optimistically or on-chain. * @param aggregateRoot The aggregate root propagated * @param domainsHash The current domain hash */ diff --git a/packages/deployments/contracts/contracts_forge/core/connext/libraries/AssetLogic.t.sol b/packages/deployments/contracts/contracts_forge/core/connext/libraries/AssetLogic.t.sol index 91684031c9..d3a88f4565 100644 --- a/packages/deployments/contracts/contracts_forge/core/connext/libraries/AssetLogic.t.sol +++ b/packages/deployments/contracts/contracts_forge/core/connext/libraries/AssetLogic.t.sol @@ -310,7 +310,7 @@ contract AssetLogicTest is BaseConnextFacet, FacetHelper { // ============ swapToLocalAssetIfNeeded ============ - // doesnt swap + // doesn't swap function test_AssetLogic__swapToLocalAssetIfNeeded_worksIfZero() public { utils_swapToLocalAndAssertViaExternal(_adopted, 0, 10000, 1_000); } @@ -327,7 +327,7 @@ contract AssetLogicTest is BaseConnextFacet, FacetHelper { // ============ swapFromLocalAssetIfNeeded ============ - // doesnt swap + // doesn't swap function test_AssetLogic__swapFromLocalAssetIfNeeded_worksIfZero() public { utils_swapFromLocalAndAssertViaExternal(_local, 0, 0.1 ether, 1_000, 0 ether); } diff --git a/packages/deployments/subgraph/src/amarok-hub-staging/mapping/rootManager.ts b/packages/deployments/subgraph/src/amarok-hub-staging/mapping/rootManager.ts index c8f9f071b1..cfd3caa104 100644 --- a/packages/deployments/subgraph/src/amarok-hub-staging/mapping/rootManager.ts +++ b/packages/deployments/subgraph/src/amarok-hub-staging/mapping/rootManager.ts @@ -17,7 +17,7 @@ import { import { OptimisticRootPropagated, - RootAggregated, //TOOD: V1.1 Remove + RootAggregated, //TODO: V1.1 Remove RootManagerMeta, RootManagerMode, OptimisticRootProposed, diff --git a/packages/integration/README.md b/packages/integration/README.md index 43b2b85d6c..71a7d8e26e 100644 --- a/packages/integration/README.md +++ b/packages/integration/README.md @@ -16,7 +16,7 @@ A test script to validate the end-to-end cross-chain transfer process. ### 2. Environment Variables -In your local environment, relpace `sha-0c08528` to the latest sha build tag from CI you want to use, run the following commands to export env variables which will be used in the local e2e runtime environment: +In your local environment, replace `sha-0c08528` to the latest sha build tag from CI you want to use, run the following commands to export env variables which will be used in the local e2e runtime environment: ```sh export ROUTER_PUBLISHER_IMAGE='ghcr.io/connext/router-publisher:sha-0c08528'