Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desired Outcome
The desired outcome of this PR is to resolve a segfault that occurs if the user running
conjur-preflight
doesn't have permission on some of the partition mount points. This manifested with the crash error:Implemented Changes
Previously, an error returned by the usage check was ignored, which led to attempting to read uninitialized memory, leading to the segfault. This error is now properly handled to log it and continue processing.
This PR also fixes all other instances of this class of error. These were not causing issues at the moment, but there are now no unhandled error responses in the project.
Finally, I added the necessary unit tests to include coverage of these scenarios.
Connected Issue/Story
CNJR-830
Definition of Done
At least 1 todo must be completed in the sections below for the PR to be
merged.
Changelog
CHANGELOG update
Test coverage
changes, or
Documentation
README
s) were updated in this PRBehavior
Security