Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.21.x] enforce local resource start/stop ordering #589

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

shouples
Copy link
Contributor

Summary of Changes

Enforce starting Kafka first, and stopping it last. May need refinement later as more resource types are added.

Pull request checklist

Please check if your PR fulfills the following (if applicable):

Tests
  • Added new
  • Updated existing
  • Deleted existing
Other
  • All new disposables (event listeners, views, channels, etc.) collected as for eventual cleanup?
  • Does anything in this PR need to be mentioned in the user-facing CHANGELOG or README?
  • Have you validated this change locally by packaging and installing the extension .vsix file?
    gulp clicktest

@shouples shouples requested a review from a team as a code owner November 14, 2024 15:26
@shouples shouples merged commit 1d943d7 into v0.21.x Nov 14, 2024
1 check passed
@shouples shouples deleted the djs/resource-stop-order branch November 14, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants