cleanup: refactor connections management for local #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
airlock-confluentinc
bot
force-pushed
the
djs/local-connections-update
branch
2 times, most recently
from
786cd70
to
a8ba74c
Compare
airlock-confluentinc
bot
force-pushed
the
djs/local-kafka-shutdown
branch
from
3f9ad67
to
d247571
Compare
airlock-confluentinc
bot
force-pushed
the
djs/local-connections-update
branch
from
a8ba74c
to
3af86d4
Compare
airlock-confluentinc
bot
force-pushed
the
djs/local-kafka-shutdown
branch
from
d247571
to
4e816e2
Compare
airlock-confluentinc
bot
force-pushed
the
djs/local-connections-update
branch
from
3af86d4
to
12b15f4
Compare
airlock-confluentinc
bot
force-pushed
the
djs/local-kafka-shutdown
branch
from
4e816e2
to
7751010
Compare
airlock-confluentinc
bot
force-pushed
the
djs/local-connections-update
branch
from
12b15f4
to
699fef1
Compare
airlock-confluentinc
bot
force-pushed
the
djs/local-kafka-shutdown
branch
from
7751010
to
824246d
Compare
5 tasks
airlock-confluentinc
bot
force-pushed
the
djs/local-connections-update
branch
from
699fef1
to
0afa6a6
Compare
5 tasks
airlock-confluentinc
bot
force-pushed
the
djs/local-connections-update
branch
from
d886b68
to
c812577
Compare
jlrobins
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Mainly moving the get/create local connection functionality to
src/sidecar/connections.tsinstead of where it previously lived (src/graphql/local.ts), to be more generally-usable.Also added some new tests since
src/sidecar/connections.tswas largely uncovered, and we have a couple new core functions for getting/creating connections for a spec. We could stand to break some of these out into not-mocked/-stubbed tests, but with the direct connect updates coming, I'd like to hold off for a bit.Pull request checklist
Please check if your PR fulfills the following (if applicable):
Tests
Other
.vsixfile?