Make webview cache render templates and track multiple panels per id #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noeldevelops
approved these changes
Oct 23, 2024
| ); | ||
| context.subscriptions.push(scaffoldProjectCommand); | ||
| }; | ||
|
|
||
| export const scaffoldProjectRequest = async (context: ExtensionContext) => { | ||
| export const scaffoldProjectRequest = async () => { |
| @@ -139,7 +139,7 @@ | |||
| color: var(--vscode-input-foreground); | |||
| background: var(--vscode-input-background); | |||
| border-radius: 3px; | |||
| border: 2px solid var(--vscode-input-border); | |||
| border: 1px solid var(--vscode-dropdown-border); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for #427. In the original implementation I tracked duplicate tabs with unique IDs, so if the original tab was closed, clicking on Play button in the sidebar would not be able to switch to other existing tabs of the same topic. Fixing it here by moving this responsibility to webview cache. The cache now tracks lists of panels per ID, and if
multipleflag is enabled, it can create a new panel for the id that already has other panels. This resolves the mentioned issue and makes it possible to follow similar pattern in the future for other type of webviews.Another thing I'm addressing here is the bootstrap code we need to deal with when instantiating a webview. Primarily the part about rendering the template and link static assets to the webview. This now happens inside the webview cache. When instantiating a webview, you need to provide the template function (which is generated in build time) and the template itself should use
${path('file.css')}expressions in places where the static link is needed. Just like before, you need to make sure this file is prebuilt.@noeldevelops while testing, I found a style issue in default light theme where text inputs in scaffold forms didn't have any border. Updated in
uikit.cssthe missing color.