Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up some ResourceManager methods and perhaps storage keys #682

Open
jlrobins opened this issue Nov 25, 2024 · 0 comments
Open

Clean up some ResourceManager methods and perhaps storage keys #682

jlrobins opened this issue Nov 25, 2024 · 0 comments
Assignees
@jlrobins
Labels
cleanup General refactoring and/or minor adjustments needed that shouldn't impact overall functionality good first issue Good for newcomers
Milestone
2024 Q4 General I...

Comments

@jlrobins
Copy link
Contributor

jlrobins commented Nov 25, 2024 •
edited
Loading

The following ResourceManager methods are no longer called from real codebase code and should be removed, along with their corresponding storage keys.

  • getClusterForTopic
  • deleteLocalKafkaClusters
  • getLocalKafkaCluster
  • getLocalKafkaClusters
  • setLocalKafkaClusters (and one caller in resources.ts should be removed, since no calls to getLocalKafkaClusters()

More along this line of cleanup in the future.
@jlrobins jlrobins added good first issue Good for newcomers cleanup General refactoring and/or minor adjustments needed that shouldn't impact overall functionality labels Nov 25, 2024
@jlrobins jlrobins added this to the 2024 Q4 General Improvements milestone Nov 25, 2024
@jlrobins jlrobins self-assigned this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jlrobins jlrobins

Labels
cleanup General refactoring and/or minor adjustments needed that shouldn't impact overall functionality good first issue Good for newcomers
Projects
None yet
Milestone
2024 Q4 General Improvements
Development

No branches or pull requests
1 participant
@jlrobins