Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KSQL UDF and UDAFs can have non-optional return schemas #2769

Closed
big-andy-coates opened this issue May 2, 2019 · 0 comments · Fixed by #2768
Closed

KSQL UDF and UDAFs can have non-optional return schemas #2769

big-andy-coates opened this issue May 2, 2019 · 0 comments · Fixed by #2768

Comments

@big-andy-coates
Copy link
Contributor

The fields in the row schema in KSQL as supposed to always be optional. This is work @rodesai did previously. This is important because at the moment if a UDF throws an exception while processing a field KSQL outputs the row with a null value in the field. So fields must be nullable.

However, while introducing KsqlSchema recently I noted there are some points in the code base where this is not being adhered to: UDF and UDAF return values!

Obviously, in time we'll likely want to support NOT NULL column defs. But that requires some thought! Until that happens, we should be consistent and always have nullable fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant