Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't create TransactionalProducer if all statements in request are non-distributed #3795

Closed
stevenpyzhang opened this issue Nov 7, 2019 · 1 comment
Assignees

Comments

@stevenpyzhang
Copy link
Member

Is your feature request related to a problem? Please describe.
#3660 introduced a Transactional Producer protocol to the command topic. A new producer is created for every request to the KsqlResource, even if the statements don't need to be enqueued in the command topic.

Describe the solution you'd like
Make the Transactional Producer an optional. When a request is received, parse all the statements and search through them to see if a distributed statement is present. If it is, create a Transactional Producer.

@stevenpyzhang
Copy link
Member Author

This isn't an issue anymore since the producer has been moved to only be created in the DistributingExecutor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant