-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support DECIMAL literals #3593
Comments
Perhaps this isn't desired behavior, but you can currently use |
We should consider make a breaking change in the next major version so that Marking for 6.0 release. |
When we switch to proper decimal support we should remove the magic around string -> decimal coercion. e.g. in INSERT VALUES functionality, and in ExpectedRecordComparator.java |
Similar to #3591 but for DECIMALs.
We need a way for users to construct decimals. Currently, our SQL parsing rules handle DECIMAL creation:
However, this is converted to a
DoubleLiteral
inParserUtil
:Given we don't support implicit conversion of
DOUBLE
->DECIMAL
, and any such conversion would be potentially lossy anyway, it means we don't have any way for users to createDECIMAL
literals to use inINSERT VALUES
or indeed to createDECIMAL
s to use in any other part of our SQL dialect.We should look to change our current decimal parsing to return a
DECIMAL
literal, though doing so would be a breaking change without careful management. We can maybe look to add a compatibility breaking config to decide how decimals should be parsed, and then look to remove this option in the next major release.The text was updated successfully, but these errors were encountered: