fix: don't display decimals in scientific notation in CLI (#4723)

fixes: #4722 This change sees decimals being returned by the rest api avoiding use of scientific notation. For example, a decimal such as `100` will be returned as `100` and not `1e+2`. The CLI just displays what it given. Co-authored-by: Andy Coates <[email protected]>
confluentinc · Mar 10, 2020 · 3626f42 · 3626f42
1 parent 6cdd753
commit 3626f42
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/ksql-common/src/main/java/io/confluent/ksql/json/JsonMapper.java b/ksql-common/src/main/java/io/confluent/ksql/json/JsonMapper.java
@@ -32,5 +32,6 @@ public enum JsonMapper {
     mapper.registerModule(new KsqlTypesSerializationModule());
     mapper.disable(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES);
     mapper.enable(DeserializationFeature.USE_BIG_DECIMAL_FOR_FLOATS);
+    mapper.enable(JsonGenerator.Feature.WRITE_BIGDECIMAL_AS_PLAIN);
   }
 }
diff --git a/ksql-common/src/test/java/io/confluent/ksql/json/JsonMapperTest.java b/ksql-common/src/test/java/io/confluent/ksql/json/JsonMapperTest.java
@@ -21,6 +21,7 @@
 import com.fasterxml.jackson.core.JsonGenerator;
 import com.fasterxml.jackson.databind.DeserializationFeature;
 import com.fasterxml.jackson.databind.ObjectMapper;
+import java.math.BigDecimal;
 import org.junit.Test;
 
 public class JsonMapperTest {
@@ -36,4 +37,13 @@ public void shouldNotAutoCloseTarget() {
   public void shouldIgnoreUnknownProperties() {
     assertThat(OBJECT_MAPPER.isEnabled(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES), is(false));
   }
+
+  @Test
+  public void shouldNotUseScientificNotationWhenSerializingDecimals() throws Exception {
+    // When:
+    final String result = OBJECT_MAPPER.writeValueAsString(new BigDecimal("1e+1"));
+
+    // Then:
+    assertThat(result, is("10"));
+  }
 }