-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'data.stream.namespace' configuration property #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎉 All Contributor License Agreements have been signed. Ready to merge. |
This comment has been minimized.
This comment has been minimized.
airlock-confluentinc
bot
force-pushed
the
CC-29637
branch
from
October 21, 2024 08:51
cc8d387
to
9eb6a59
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
airlock-confluentinc
bot
force-pushed
the
CC-29637
branch
from
October 21, 2024 09:20
9eb6a59
to
c5eea3f
Compare
This comment has been minimized.
This comment has been minimized.
sp-gupta
previously approved these changes
Oct 21, 2024
srishti-saraswat
dismissed
sp-gupta’s stale review
October 21, 2024 11:39
The base branch was changed.
airlock-confluentinc
bot
force-pushed
the
CC-29637
branch
from
October 21, 2024 11:40
c5eea3f
to
f183475
Compare
This comment has been minimized.
This comment has been minimized.
airlock-confluentinc
bot
force-pushed
the
CC-29637
branch
from
October 21, 2024 12:23
f183475
to
dc539b7
Compare
sp-gupta
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Original PR - #742
PR to expose this config on cloud - https://github.com/confluentinc/kafka-connect-elasticsearch-private/pull/43
Solution
Does this solution apply anywhere else?
If yes, where?
Test Strategy
Tested using docker playground
Case 1: correct data stream namespace
connector configs -
result -
Case 2: incorrect data stream namespace
connector configs -
result -
Testing done:
Release Plan