Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could you please add a Assembly Signature for your library in the next release version? #973

Closed
4 tasks
longbaochenlong opened this issue Jun 4, 2019 · 6 comments

Comments

@longbaochenlong
Copy link

Description

My Dear Friend,Could you please add a Assembly Signature for your library in the next release version?Thanks!

Checklist

Please provide the following information:

  • Confluent.Kafka 1.0.1.1.
  • Apache Kafka 1.0.1.
  • Windows10.
  • Assembly Signature.
@mhowlett
Copy link
Contributor

mhowlett commented Jun 5, 2019

yes, we do plan to do this soon.

@zhoubo56
Copy link

Our team want change projects into "Strong-naming Assemblies", got the same issue. As the reminder here, we can get the update release immediately.

@mhowlett
Copy link
Contributor

mhowlett commented Jul 1, 2019

we'll try to get to this this week and put out a 1.1.0.1.

@mhowlett
Copy link
Contributor

mhowlett commented Jul 2, 2019

this is more effort than I was initially thinking. here's a start: #1000 ... there are issues. I think it's too big a scope for me to get done on the side without getting the ok from product. If you get this working (will also need a PR against our avro fork to make it signed), I can prioritize merging it. It seems like we really only need signed assemblies? (based on what other projects seem to do). seems the downsides to doing that are not material.

@mhowlett
Copy link
Contributor

mhowlett commented Jul 3, 2019

just doing a bit of research on this ... I now recall that this blog post is responsible for us deciding to distribute a separate signed assembly. however, it seems that advice is no longer good: https://www.pedrolamas.com/2018/09/11/start-strong-naming-your-assemblies/

so, it seems we should move to signing all assemblies and get rid of the separate Confluent.Kafka.StrongName.

@anchitj
Copy link
Member

anchitj commented Jun 18, 2024

Closing as it's fixed now.

@anchitj anchitj closed this as completed Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants