Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate uninstaller tests on Windows hanging if the path contains spaces #603

Open
jaimergp opened this issue Jan 10, 2023 · 1 comment
Labels
stale::recovered [bot] recovered after being marked as stale stale [bot] marked as stale due to inactivity type::testing issues about tests or the test infrastructure

Comments

@jaimergp
Copy link
Contributor

See #449 (comment) (note it might be hidden). Copying here for reference:

The win un-installers fail (run forever if not killed by the p.communicate(timeout)).... still all files seem to be removed. Reverting back to an env_dir without space makes it finish without timeout

and

This PR was created and afaik running green before the uninstaller test PR was merged #569

Now with the uninstaller test PR merged, there is the following situation:

  • the windows uninstallers hang consuming lots of action runner minutes without deleting anything
  • Added a timeout to the test command execution which is visible in the test execution log
  • If the spaces are removed on windows, then the installers won't hang.
  • Spaces on windows should (!?) work anyway already due to windows having spaces in path since long... like C:\Program Files\...
  • The uninstallers even hang when commenting almost everything out in the uninstall section in main.nsi.tmpl, see tests done here Patch 1 dbast/constructor#3
@jaimergp jaimergp added the type::testing issues about tests or the test infrastructure label Jan 10, 2023
Copy link

Hi there, thank you for your contribution!

This issue has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this issue to remain open please:

  1. Verify that you can still reproduce the issue at hand
  2. Comment that the issue is still reproducible and include:
    - What OS and version you reproduced the issue on
    - What steps you followed to reproduce the issue

NOTE: If this issue was closed prematurely, please leave a comment.

Thanks!

@github-actions github-actions bot added the stale [bot] marked as stale due to inactivity label Jan 11, 2024
@github-actions github-actions bot added the stale::closed [bot] closed after being marked as stale label Feb 10, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 10, 2024
@github-project-automation github-project-automation bot moved this to 🏁 Done in 🧭 Planning Feb 10, 2024
@jaimergp jaimergp added stale::recovered [bot] recovered after being marked as stale and removed stale::closed [bot] closed after being marked as stale labels Feb 15, 2024
@jaimergp jaimergp reopened this Feb 15, 2024
@github-project-automation github-project-automation bot moved this from 🏁 Done to 🏗️ In Progress in 🧭 Planning Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale::recovered [bot] recovered after being marked as stale stale [bot] marked as stale due to inactivity type::testing issues about tests or the test infrastructure
Projects
Status: 🏗️ In Progress
Development

No branches or pull requests

1 participant