Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.2.0 #220

Closed
9 of 18 tasks
dholth opened this issue Aug 2, 2023 · 4 comments
Closed
9 of 18 tasks

Release 2.2.0 #220

dholth opened this issue Aug 2, 2023 · 4 comments
Assignees
Labels
locked [bot] locked due to inactivity

Comments

@dholth
Copy link
Contributor

dholth commented Aug 2, 2023

Summary

Placeholder for conda-package-handling 2.2.0 release.

| Pilot | dholth |

Tasks

The week before release week

  • Create release branch (named YY.M.x)
  • Ensure release candidates are being successfully built (see conda-canary/label/YY.M.x)
  • Complete outstanding PRs
  • Test release candidates

Release week

Linked Issues & PRs

@dholth dholth added the epic a highlevel collection of smaller related issues label Aug 2, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in 🧭 Planning Aug 2, 2023
@dholth dholth self-assigned this Aug 2, 2023
@dholth dholth removed the epic a highlevel collection of smaller related issues label Aug 2, 2023
@dholth dholth moved this from 🆕 New to 🏗️ In Progress in 🧭 Planning Aug 2, 2023
@beckermr
Copy link
Contributor

beckermr commented Aug 2, 2023

The bot found that v2.2.0 now imports zstandard but the dependencies have not been updated here in this repo. See conda-forge/conda-package-handling-feedstock#75

@dholth
Copy link
Contributor Author

dholth commented Aug 2, 2023

@beckermr It is designed to work without zstandard "in case of emergency" https://github.com/conda/conda-package-handling/blob/main/src/conda_package_handling/api.py#L28-L29

It should depend on conda-package-streaming >=0.9.0 to pull in a conda-package-streaming umask fix.

conda-package-streaming depends on zstandard.

@beckermr
Copy link
Contributor

beckermr commented Aug 2, 2023

The bot explicitly checks for guarded imports. Are you sure this one is guarded? I cannot tell from the code base.

@dholth
Copy link
Contributor Author

dholth commented Aug 2, 2023

It would be appropriate to depend on zstandard directly.

We test the alternate case here since if you don't have zstandard, it would be really nice to be able to install it. https://github.com/conda/conda-package-handling/blob/main/tests/test_degraded.py

@dholth dholth moved this from 🏗️ In Progress to ✅ Approved in 🧭 Planning Sep 28, 2023
@dholth dholth moved this from ✅ Approved to 🏁 Done in 🧭 Planning Oct 18, 2023
@dholth dholth closed this as completed Oct 18, 2023
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Aug 27, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked [bot] locked due to inactivity
Projects
Archived in project
Development

No branches or pull requests

2 participants