Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase test coverage for (and update) root_signing.py #75

Merged
merged 25 commits into from
Aug 22, 2023
Merged

Increase test coverage for (and update) root_signing.py #75

merged 25 commits into from
Aug 22, 2023

Conversation

beeankha
Copy link
Member

@beeankha beeankha commented Aug 21, 2023 •
edited by dholth
Loading

Description

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@beeankha beeankha added source::anaconda created by members of Anaconda, Inc. type::testing issues about tests or the test infrastructure labels Aug 21, 2023
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Aug 21, 2023
@beeankha
Update root_signing.py
2fc069b
@beeankha
Remove _verify_gpg_sig_using_ssl
c38e1e6 
This funtion was only in the codebase for testing purposes and is not referenced anywhere
@beeankha
Remove _gpg_pubkey_in_ssl_format function
07bbd9e 
This function was only for testing purposes and is not referenced anywhere in the codebase
@beeankha
Remove _gpgsig_to_sslgpgsig and _sslgpgsig_to_gpgsig
ec5c8e9 
These functions were commented out
dholth
dholth reviewed Aug 21, 2023
View reviewed changes
tests/test_root.py Outdated Show resolved Hide resolved
@dholth
Copy link
Contributor

dholth commented Aug 21, 2023 •
edited
Loading

Great cleanups. I tried installing gpg and couldn't get certain existing tests to pass; possibly would have to create a key locally first? FAILED tests/test_root.py::test_root_gen_sign_verify - securesystemslib.gpg.exceptions.CommandError: Command '['gpg', '--detach-sign', '--digest-algo', 'SHA256', '--local-user', '917adb684e2e9fb5ed4e5...

@awwad will we ever use GPG signing for this system?

dholth
dholth previously approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@dholth dholth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

awwad
awwad reviewed Aug 21, 2023
View reviewed changes
tests/test_root.py Outdated Show resolved Hide resolved
awwad
awwad reviewed Aug 21, 2023
View reviewed changes
tests/test_root.py Outdated Show resolved Hide resolved
awwad
awwad reviewed Aug 21, 2023
View reviewed changes
tests/test_root.py Outdated Show resolved Hide resolved
jezdez
jezdez reviewed Aug 22, 2023
View reviewed changes
.github/workflows/tests.yml Outdated Show resolved Hide resolved
jezdez
jezdez reviewed Aug 22, 2023
View reviewed changes
tests/requirements.txt Outdated Show resolved Hide resolved
@dholth dholth marked this pull request as ready for review August 22, 2023 18:29
@dholth dholth mentioned this pull request Aug 22, 2023
Closed
3 tasks
kenodegard
kenodegard reviewed Aug 22, 2023
View reviewed changes
tests/requirements.txt Outdated Show resolved Hide resolved
dholth
dholth approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@dholth dholth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dholth dholth merged commit 1f4e6b2 into conda:main Aug 22, 2023
16 checks passed
@jezdez jezdez mentioned this pull request Aug 23, 2023
Merged
1 task
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Aug 22, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@awwad awwad awwad left review comments

@kenodegard kenodegard kenodegard left review comments

@jezdez jezdez jezdez left review comments

@dholth dholth dholth approved these changes

Assignees
No one assigned
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity source::anaconda created by members of Anaconda, Inc. type::testing issues about tests or the test infrastructure
Projects
🔎 Review
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@beeankha @dholth @jezdez @kenodegard @awwad @conda-bot