Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow list for binary files that can contain non-unicode characters for noarch scripts #5385

Open
2 tasks done
hmaarrfk opened this issue Jun 22, 2024 · 0 comments
Open
2 tasks done
Labels
type::feature request for a new feature or capability

Comments

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Jun 22, 2024

Checklist

  • I added a descriptive title
  • I searched open requests and couldn't find a duplicate

What is the idea?

The spyder feedstock contains an ico file that cannot be decoded with UTF-8.

xref: conda-forge/spyder-feedstock#177

This is triggering the test

sys.exit(f"[noarch_python] Noarch package contains binary script: {fn}")

to fail causing the build to fail

Why is this needed?

Handle packaging edge cases like this

What should happen?

The build should pass

Additional Context

Maybe the ico file could be moved, but ensuring that icons work well is generally difficult.

@hmaarrfk hmaarrfk added the type::feature request for a new feature or capability label Jun 22, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in 🧭 Planning Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type::feature request for a new feature or capability
Projects
Status: 🆕 New
Development

No branches or pull requests

1 participant