Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipes defining outputs without package/version fail in 3.28.0 #5097

Closed
kenodegard opened this issue Dec 5, 2023 · 2 comments · Fixed by #5096
Closed

Recipes defining outputs without package/version fail in 3.28.0 #5097

kenodegard opened this issue Dec 5, 2023 · 2 comments · Fixed by #5096
Assignees
Labels
in-progress issue is actively being worked on locked [bot] locked due to inactivity severity::2 critical; broken functionality with an unacceptably complex workaround source::community catch-all for issues filed by community members type::bug describes erroneous operation, use severity::* to classify the type

Comments

@kenodegard
Copy link
Contributor

kenodegard commented Dec 5, 2023

What happened?

#5055 corrected how the metadata's version was validated and resulted in multi outputs failing to build unless they also define the top level package/version.

Xref conda-forge/admin-requests#890

Conda Details

conda info
     active environment : None
            shell level : 0
       user config file : /Users/kodegard/.condarc
 populated config files : /Users/kodegard/.condarc
          conda version : 23.11.0
    conda-build version : 3.28.0
         python version : 3.10.13.final.0
                 solver : libmamba (default)
       virtual packages : __archspec=1=m1
                          __conda=23.11.0=0
                          __osx=13.6=0
                          __unix=0=0
       base environment : /Users/kodegard/.conda/arm64/23.10.0/3.11  (writable)
      conda av data dir : /Users/kodegard/.conda/arm64/23.10.0/3.11/etc/conda
  conda av metadata url : None
           channel URLs : https://repo.anaconda.com/pkgs/main/osx-arm64
                          https://repo.anaconda.com/pkgs/main/noarch
                          https://repo.anaconda.com/pkgs/r/osx-arm64
                          https://repo.anaconda.com/pkgs/r/noarch
          package cache : /Users/kodegard/.conda/arm64/23.10.0/3.11/pkgs
                          /Users/kodegard/.conda/pkgs
       envs directories : /Users/kodegard/.conda/arm64/23.10.0/3.11/envs
                          /Users/kodegard/.conda/envs
               platform : osx-arm64
             user-agent : conda/23.11.0 requests/2.31.0 CPython/3.10.13 Darwin/22.6.0 OSX/13.6 solver/libmamba conda-libmamba-solver/23.11.1 libmambapy/1.5.3
                UID:GID : 501:20
             netrc file : None
           offline mode : False
@kenodegard kenodegard added type::bug describes erroneous operation, use severity::* to classify the type severity::2 critical; broken functionality with an unacceptably complex workaround source::community catch-all for issues filed by community members in-progress issue is actively being worked on labels Dec 5, 2023
@kenodegard kenodegard self-assigned this Dec 5, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in 🧭 Planning Dec 5, 2023
@kenodegard kenodegard pinned this issue Dec 5, 2023
@kenodegard
Copy link
Contributor Author

Before #5055, where package/version (e.g., None) is cast to a string (e.g., "None") before validation:

def version(self):
res = str(self.get_value("package/version"))
if res is None:
sys.exit("Error: package/version missing in: %r" % self.meta_path)

After #5055, where package/version is validated before cast to a string:

def version(self) -> str:
version = self.get_value("package/version", "")
if not version and self.final:
sys.exit("Error: package/version missing in: %r" % self.meta_path)
version = str(version)

@jezdez
Copy link
Member

jezdez commented Dec 6, 2023

Fixed by #5096.

@jezdez jezdez closed this as completed Dec 6, 2023
@github-project-automation github-project-automation bot moved this from 👀 In Review to 🏁 Done in 🧭 Planning Dec 6, 2023
@kenodegard kenodegard unpinned this issue Jan 8, 2024
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Aug 20, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
in-progress issue is actively being worked on locked [bot] locked due to inactivity severity::2 critical; broken functionality with an unacceptably complex workaround source::community catch-all for issues filed by community members type::bug describes erroneous operation, use severity::* to classify the type
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants