Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests in a folder with a long path #1762

Closed
isuruf opened this issue Feb 24, 2017 · 8 comments
Closed

Run tests in a folder with a long path #1762

isuruf opened this issue Feb 24, 2017 · 8 comments
Labels
locked [bot] locked due to inactivity
Milestone

Comments

@isuruf
Copy link
Contributor

isuruf commented Feb 24, 2017

This would reveal any problems of installing the package into a folder with a long path.

@msarahan
Copy link
Contributor

Can you point to problems you've encountered? I am aware of conda installing things into paths longer than 260 characters on Windows causing problems. I'm not aware of any issues on mac or linux, though.

@isuruf
Copy link
Contributor Author

isuruf commented Feb 24, 2017

It's not a problem of conda-build. It was a problem in the package itself. (It was storing where the package was installed in a buffer too small.)
When building the package with conda-build if the test environment had a long prefix, I would have noticed this problem

Ref: conda-forge/gap-feedstock#4

@msarahan
Copy link
Contributor

Ah, I think that is actually a problem with conda-build, though. I think this is the same as #1674 - conda-build is not accounting for the null terminator or something like that. But I though our prefix is 255 chars - your 256 char buf should have been enough?

@isuruf
Copy link
Contributor Author

isuruf commented Feb 24, 2017

It wasn't storing the prefix, it was storing <prefix>/lib/gap which is longer than 256 because prefix is 256 chars long.

@msarahan
Copy link
Contributor

all right. Well, it's easy to turn on since we already have it for the build env, so I'll go ahead and implement this sometime soon.

@isuruf
Copy link
Contributor Author

isuruf commented Feb 24, 2017

Thanks.

@msarahan
Copy link
Contributor

msarahan commented Mar 8, 2017

fixed by #1799 - closing

@msarahan msarahan closed this as completed Mar 8, 2017
@github-actions
Copy link

Hi there, thank you for your contribution!

This issue has been automatically locked because it has not had recent activity after being closed.

Please open a new issue if needed.

Thanks!

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Apr 15, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked [bot] locked due to inactivity
Projects
None yet
Development

No branches or pull requests

2 participants